This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
Relative link to MDX files in docs partials #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeffgaynor
suggested changes
May 13, 2022
There was a problem hiding this comment.
I would like to test this out locally. Can you include a sample page, or link to a page where this is used in your PR Conversation? It would be good to have that added to a comment in the code as well, so other developers can understand what this does / how to use it / why it's there.
iAdramelk
previously approved these changes
May 13, 2022
jeffgaynor
reviewed
May 18, 2022
| * i.e. start realtive paths from the partial file directory, not from place where it is being inserted | ||
| * example: | ||
| * main file: docs/page/1.mdx | ||
| * partial: docs/partials/headers/1.mdx |
There was a problem hiding this comment.
Thanks for adding these comments: What is the syntax for partials? Maybe indicate this in the comment:
* main file: docs/page/1.mdx
* partial: (!docs/partials/headers/1.mdx!)
* With this utility a partial like
* (!../image.jpg!)
jeffgaynor
approved these changes
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct relative paths resolving in partial docs
i.e. start realtive paths from the partial file directory, not from place where it is being inserted
example:
main file:
docs/page/1.mdxpartial:
docs/includes/headers/1.mdxWith this utility path like that
../getting-startedin partial will be pointing to
docs/partials/getting-startedand without:
docs/getting-started